feat: support both light and dark logo variants #3023
Conversation
|
The image is available at: |
logonoff
changed the title
|
The image is available at: |
logonoff
changed the title
|
The image is available at: |
|
The image is available at: |
|
The image is available at: |
|
The image is available at: |
|
The image is available at: |
|
/cc @its-mitesh-kumar |
|
The image is available at: |
|
The image is available at: |
|
The image is available at: |
|
The image is available at: |
|
The image is available at: |
|
/cc |
|
@logonoff , I am adding custom fullLogo, but I am seeing default RHDH Logo. Here is the screenshot |
|
Yep, I just wanted report the same. With light and dark it works fine. But when I use a simple string (old format) it doesn't work as expected. I saw also two other issues, but I expect this should be fixed in the global-header:
The outer div of the company logo has a width of 224px. But the padding on the left has also 24px. I guess the design team inlcudes this 24px in their "it should be 224px wide". So I expect we can go with 200px width on the outer div. And then I see there the issue that the icon is neigher left or center aligned. The inner logo has a max-width of 150px. Couldn't we just use the full width? Which means 176px at the moment, right?
For this PR it's required that the old configuration is supported. I can create a bug for the sizing/alignment issue if needed. |
|
The image is available at: |
|
The image is available at: |
fixed (using @its-mitesh-kumar's
|
fixes an "oepsie woepsie," if you will
includes all the changes in RHDH PR 2893, but a newer version to prevent a runtime error
…nd application launcher includes changes from PR 3039
|
The image is available at: |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: christoph-jerolimov, ciiay The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
christoph-jerolimov
merged commit 84665bd
into
redhat-developer:main
|
@logonoff: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
* fix(SidebarLogo): support both light and dark variants * fix(favicon): support light and dark variants * feat: replace janus fallback with RHDH, remove duplicated RHDH logo from app config also part of https://issues.redhat.com/browse/RHIDP-3227 * fix: update the theme again, do not target classnames fixes an "oepsie woepsie," if you will * feat(global-header): add CompanyLogo to global-header includes all the changes in RHDH PR 2893, but a newer version to prevent a runtime error * feat(global-header): update default header, enable starred dropdown and application launcher includes changes from PR 3039
* fix(SidebarLogo): support both light and dark variants * fix(favicon): support light and dark variants * feat: replace janus fallback with RHDH, remove duplicated RHDH logo from app config also part of https://issues.redhat.com/browse/RHIDP-3227 * fix: update the theme again, do not target classnames fixes an "oepsie woepsie," if you will * feat(global-header): add CompanyLogo to global-header includes all the changes in RHDH PR 2893, but a newer version to prevent a runtime error * feat(global-header): update default header, enable starred dropdown and application launcher includes changes from PR 3039
5 participants
Description
Modifies
app.branding.fullLogoandapp.branding.iconLogoto also accept an object that containslightanddark.RHDH now has this behaviour for the sidebar logo:
app.branding.fullLogois a string, it will be shown in both light and dark theme.app.branding.fullLogois an object, the image associated withdarkkey will be shown in application dark theme, and vice versaRHDH now has this behaviour for the favicon:
app.branding.iconLogois a string, it will be shown in both light and dark theme.app.branding.iconLogois an object, the image associated withdarkkey will be shown when the system is in dark theme (that is we use theprefers-color-schememedia query), and vice versaMoreover, the default RHDH
app.branding.fullLogoandapp.branding.iconLogohas been removed in favour of updating the fallbackLogoFullandLogoIconfrom Janus branding to RHDH.This behaviour is similar to other Red Hat products, such as OCP console, as described in openshift/enhancements#1753
demo:
Screencast.From.2025-06-20.10-41-47.mp4
(note the kiwi, banana, and non-official RHDH logo do not reflect the app-config changes I made--the app-configs I changed align with brand)
Which issue(s) does this PR fix
https://issues.redhat.com/browse/RHIDP-7734, https://issues.redhat.com/browse/RHIDP-3227, https://issues.redhat.com/browse/RHIDP-7593, https://issues.redhat.com/browse/RHDHPAI-907
PR acceptance criteria
Please make sure that the following steps are complete:
How to test changes / Special notes to the reviewer